Source/bindings/templates/methods.cpp - Issue 1035023005: [bindings] Support CallWith=ThisValue for generic interface methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 1035023005: [bindings] Support CallWith=ThisValue for generic interface methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/custom/V8LocationCustom.cpp ('K') | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | Source/bindings/tests/results/core/V8TestObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index e059c508cd6564ec2b09fb720ea19162e7d96fa0..865271c40531c6c912a1829f34c4513f3021fdff 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -218,7 +218,7 @@ if (!{{argument.name}}.isUndefinedOrNull() && !{{argument.name}}.isObject()) {

{######################################}

{% macro cpp_method_call(method, v8_set_return_value, cpp_value) %}

{# Local variables #}

-{% if method.is_call_with_script_state %}

+{% if method.is_call_with_script_state or method.is_call_with_this_value %}

{# [ConstructorCallWith=ScriptState] #}

{# [CallWith=ScriptState] #}

ScriptState* scriptState = ScriptState::current(info.GetIsolate());