Adding the Finch code for the certificate error reporter experiment

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
+#include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/interstitials/security_interstitial_page_test_utils.h"
 #include "chrome/browser/net/certificate_error_reporter.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/ping_manager.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/variations/variations_associated_data.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 1077 matching lines @@
 
   CheckAuthenticatedState(browser()->tab_strip_model()->GetActiveWebContents(),
                           AuthState::DISPLAYED_INSECURE_CONTENT);
 }
 
 // Test that when the checkbox is checked and the user proceeds through
 // the interstitial, the FraudulentCertificateReporter sees a request to
 // send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
                        TestBrokenHTTPSProceedWithReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",
+                                         "ShowAndPossiblySend");
+  std::map<std::string, std::string> params;
+  params["possibly_send"] = "1.0";
+  variations::AssociateVariationParams("ReportCertificateErrors",
+                                       "ShowAndPossiblySend", params);
   TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,
                            CertificateReporting::SSL_INTERSTITIAL_PROCEED,
                            CertificateReporting::CERT_REPORT_EXPECTED,
                            browser());
 }
 
 // Test that when the checkbox is checked and the user goes back (does
 // not proceed through the interstitial), the
 // FraudulentCertificateReporter sees a request to send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
                        TestBrokenHTTPSGoBackWithReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",

[estark, 2015/04/01 20:47:43]

I think this code should appear on the 4 tests below as well (all the
SSLUITestWithExtendedReporting tests). In fact, I think you could just remove
the command-line flag entirely and then replace line 527 with this code (and
make the function |SetUp| instead of |SetUpCommandLine|).

+                                         "ShowAndPossiblySend");
+  std::map<std::string, std::string> params;
+  params["possibly_send"] = "1.0";
+  variations::AssociateVariationParams("ReportCertificateErrors",
+                                       "ShowAndPossiblySend", params);
   TestBrokenHTTPSReporting(
       CertificateReporting::EXTENDED_REPORTING_OPT_IN,
       CertificateReporting::SSL_INTERSTITIAL_DO_NOT_PROCEED,
       CertificateReporting::CERT_REPORT_EXPECTED, browser());
 }
 
 // Test that when the checkbox is not checked and the user proceeds
 // through the interstitial, the FraudulentCertificateReporter does not
 // see a request to send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
@@ skipping 15 matching lines @@
       CertificateReporting::CERT_REPORT_NOT_EXPECTED, browser());
 }
 
 // Test that when the command-line switch for reporting invalid cert
 // chains is not enabled, reports don't get sent, even if the opt-in
 // preference is set. (i.e. if a user enables invalid cert collection in
 // chrome://flags, checks the box on an interstitial, and then disables
 // the flag in chrome://flags, reports shouldn't be sent on the next
 // interstitial).
 IN_PROC_BROWSER_TEST_F(SSLUITest, TestBrokenHTTPSNoReportingWithoutSwitch) {
   TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,

[estark, 2015/04/01 20:47:43]

This test is supposed to test that reports don't get sent when the user doesn't
see the checkbox. So I think this test should be adapted to include code like
lines 1150-1155, except assigning the user to the DontShowAndDontSend group.

We should then duplicate this test that's exactly the same, excepting assigning
the user to ShowAndPossiblySend with a parameter of 0.

It would be even better to additionally test that the checkbox doesn't actually
appear when the user is in the DontShowAndDontSend group (using something like
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/int...).

[estark, 2015/04/01 20:49:40]

Sorry, I failed at English on that sentence... let me rephrase:
We should then duplicate this test to have one that's exactly the same, except
assigning the user to ShowAndPossiblySend with a parameter of 0.

                            CertificateReporting::SSL_INTERSTITIAL_PROCEED,
                            CertificateReporting::CERT_REPORT_NOT_EXPECTED,
                            browser());
 }
 
 // Test that reports don't get sent in incognito mode even if the opt-in
 // preference is set and the command-line switch is enabled.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
                        TestBrokenHTTPSNoReportingInIncognito) {
   TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,
@@ skipping 964 matching lines @@
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.