Adding the Finch code for the certificate error reporter experiment

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
+#include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/interstitials/security_interstitial_page_test_utils.h"
 #include "chrome/browser/net/certificate_error_reporter.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/ping_manager.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/variations/variations_associated_data.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 467 matching lines @@
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     // Browser will ignore certificate errors on localhost.
     command_line->AppendSwitch(switches::kAllowInsecureLocalhost);
   }
 };
 
 class SSLUITestWithExtendedReporting : public SSLUITest {
  public:
   SSLUITestWithExtendedReporting() : SSLUITest() {}
-
-  void SetUpCommandLine(base::CommandLine* command_line) override {
-    // Enable a checkbox on SSL interstitials that allows users to opt
-    // in to reporting invalid certificate chains.
-    command_line->AppendSwitch(switches::kEnableInvalidCertCollection);
-  }
 };
 
 // Visits a regular page over http.
 IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTP) {
   ASSERT_TRUE(test_server()->Start());
 
   ui_test_utils::NavigateToURL(browser(),
                                test_server()->GetURL("files/ssl/google.html"));
 
   CheckUnauthenticatedState(
@@ skipping 583 matching lines @@
                                https_server_.GetURL(replacement_path));
 
   CheckAuthenticatedState(browser()->tab_strip_model()->GetActiveWebContents(),
                           AuthState::DISPLAYED_INSECURE_CONTENT);
 }
 
 // Test that when the checkbox is checked and the user proceeds through
 // the interstitial, the FraudulentCertificateReporter sees a request to
 // send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
-                       TestBrokenHTTPSProceedWithReporting) {
+                       TestBrokenHTTPSProceedWithShowCheckboxAndReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",
+                                         "ShowAndPossiblySend");
+  std::map<std::string, std::string> params;
+  params["possibly_send"] = "1.0";
+  variations::AssociateVariationParams("ReportCertificateErrors",
+                                       "ShowAndPossiblySend", params);
   TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,
                            CertificateReporting::SSL_INTERSTITIAL_PROCEED,
                            CertificateReporting::CERT_REPORT_EXPECTED,
                            browser());
 }
 
 // Test that when the checkbox is checked and the user goes back (does
 // not proceed through the interstitial), the
 // FraudulentCertificateReporter sees a request to send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
-                       TestBrokenHTTPSGoBackWithReporting) {
+                       TestBrokenHTTPSGoBackWithShowCheckboxAndReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",
+                                         "ShowAndPossiblySend");
+  std::map<std::string, std::string> params;
+  params["possibly_send"] = "1.0";
+  variations::AssociateVariationParams("ReportCertificateErrors",
+                                       "ShowAndPossiblySend", params);
   TestBrokenHTTPSReporting(
       CertificateReporting::EXTENDED_REPORTING_OPT_IN,
       CertificateReporting::SSL_INTERSTITIAL_DO_NOT_PROCEED,
       CertificateReporting::CERT_REPORT_EXPECTED, browser());
 }
 
 // Test that when the checkbox is not checked and the user proceeds
 // through the interstitial, the FraudulentCertificateReporter does not
 // see a request to send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
-                       TestBrokenHTTPSProceedWithNoReporting) {
+                       TestBrokenHTTPSProceedWithShowCheckboxAndNoReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",
+                                         "ShowAndPossiblySend");
+  std::map<std::string, std::string> params;
+  params["possibly_send"] = "-1.0";

[estark, 2015/04/02 01:19:51]

I think this should be -1.0, not 1.0. Same for the test below, which is why I
think you can move this setup code into SSLUITestWithExtendedReporting::SetUp
instead of repeating it in each test.

Why should it be 1.0? This test and the one below it are testing that a report
never gets sent if the user does not check the checkbox. Suppose we had a bug
where we were sending reports even if the checkbox wasn't checked; as is, this
test wouldn't catch that bug because the Finch param is set to -1.0 (never send
reports).

So I think these two tests should have params of 1.0, and then we should have an
additional test that tests that reports never get sent when the param is -1.0,
even if the user is opted in. This additional test would look like this:

//
// set param to -1.0 so reports never get sent
//
TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,
SSL_INTERSTITIAL_PROCEED, CERT_REPORT_NOT_EXPECTED, browser());

[fahl, 2015/04/02 17:45:29]

Done.

+  variations::AssociateVariationParams("ReportCertificateErrors",
+                                       "ShowAndPossiblySend", params);
   TestBrokenHTTPSReporting(
       CertificateReporting::EXTENDED_REPORTING_DO_NOT_OPT_IN,
       CertificateReporting::SSL_INTERSTITIAL_PROCEED,
       CertificateReporting::CERT_REPORT_NOT_EXPECTED, browser());
 }
 
 // Test that when the checkbox is not checked and the user does not proceed
 // through the interstitial, the FraudulentCertificateReporter does not
 // see a request to send a report.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
-                       TestBrokenHTTPSGoBackWithNoReporting) {
+                       TestBrokenHTTPSGoBackWithShowCheckboxAndNoReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",
+                                         "ShowAndPossiblySend");
+  std::map<std::string, std::string> params;
+  params["possibly_send"] = "-1.0";

[estark, 2015/04/02 01:19:51]

should be 1.0 as above

[fahl, 2015/04/02 17:45:29]

Done.

+  variations::AssociateVariationParams("ReportCertificateErrors",
+                                       "ShowAndPossiblySend", params);
   TestBrokenHTTPSReporting(
       CertificateReporting::EXTENDED_REPORTING_DO_NOT_OPT_IN,
       CertificateReporting::SSL_INTERSTITIAL_DO_NOT_PROCEED,
       CertificateReporting::CERT_REPORT_NOT_EXPECTED, browser());
 }
 
+// Test that when the checkbox is not shown and the user proceeds
+// through the interstitial, the FraudulentCertificateReporter does not
+// see a request to send a report.
+IN_PROC_BROWSER_TEST_F(
+    SSLUITestWithExtendedReporting,
+    TestBrokenHTTPSProceedWithNotShowCheckboxAndNoReporting) {
+  base::FieldTrialList::CreateFieldTrial("ReportCertificateErrors",
+                                         "DontShowAndDontSend");
+  TestBrokenHTTPSReporting(
+      CertificateReporting::EXTENDED_REPORTING_DO_NOT_OPT_IN,

[estark, 2015/04/02 01:19:51]

I think this should be OPT_IN. i.e. we want to test that even if the user is
opted in (because they were previously in ShowAndPossiblySend, for example), the
report does not get sent.

[fahl, 2015/04/02 17:45:28]

Done.

+      CertificateReporting::SSL_INTERSTITIAL_PROCEED,
+      CertificateReporting::CERT_REPORT_NOT_EXPECTED, browser());
+}
+
 // Test that when the command-line switch for reporting invalid cert
 // chains is not enabled, reports don't get sent, even if the opt-in
 // preference is set. (i.e. if a user enables invalid cert collection in
 // chrome://flags, checks the box on an interstitial, and then disables
 // the flag in chrome://flags, reports shouldn't be sent on the next
 // interstitial).
 IN_PROC_BROWSER_TEST_F(SSLUITest, TestBrokenHTTPSNoReportingWithoutSwitch) {
   TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,

[estark, 2015/04/02 01:19:51]

Should this test be deleted? It doesn't seem to make sense because the Finch
config is not fixed, so we don't know what the outcome will be.

[fahl, 2015/04/02 02:01:22]

Acknowledged.

[fahl, 2015/04/02 17:45:28]

Done.

                            CertificateReporting::SSL_INTERSTITIAL_PROCEED,
                            CertificateReporting::CERT_REPORT_NOT_EXPECTED,
                            browser());
 }
 
 // Test that reports don't get sent in incognito mode even if the opt-in
 // preference is set and the command-line switch is enabled.
 IN_PROC_BROWSER_TEST_F(SSLUITestWithExtendedReporting,
                        TestBrokenHTTPSNoReportingInIncognito) {
   TestBrokenHTTPSReporting(CertificateReporting::EXTENDED_REPORTING_OPT_IN,

[estark, 2015/04/02 03:22:23]

this one also needs a finch param (I think it should be ShowAndPossiblySend with
a param of 1.0)

[fahl, 2015/04/02 17:45:29]

Done.

                            CertificateReporting::SSL_INTERSTITIAL_PROCEED,
                            CertificateReporting::CERT_REPORT_NOT_EXPECTED,
                            CreateIncognitoBrowser());
 }
 
 // Visits a page that runs insecure content and tries to suppress the insecure
 // content warnings by randomizing location.hash.
 // Based on http://crbug.com/8706
 IN_PROC_BROWSER_TEST_F(SSLUITest,
                        TestRunsInsecuredContentRandomizeHash) {
@@ skipping 954 matching lines @@
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.