Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1035003002: PPC64: Fix return value checks for generated regexp code. (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
MTBrandyberry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: Fix return value checks for generated regexp code. This fixes simulated debug-mode failures in the following tests: mjsunit/regexp-stack-overflow mjsunit/regress/regress-crbug-467047 R=mbrandy@us.ibm.com BUG= Committed: https://crrev.com/fab0f042e6630cea7c78b4d8d5058d610b05a526 Cr-Commit-Position: refs/heads/master@{#27500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Next PPC patch
5 years, 9 months ago (2015-03-26 22:57:35 UTC) #1
MTBrandyberry
On 2015/03/26 22:57:35, michael_dawson wrote: > Next PPC patch lgtm
5 years, 9 months ago (2015-03-27 00:55:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035003002/1
5 years, 9 months ago (2015-03-27 13:08:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 13:30:35 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 13:30:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fab0f042e6630cea7c78b4d8d5058d610b05a526
Cr-Commit-Position: refs/heads/master@{#27500}

Powered by Google App Engine
This is Rietveld 408576698