Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1034953003: Remove flights example (Closed)

Created:
5 years, 8 months ago by abarth-chromium
Modified:
5 years, 8 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove flights example Flights is not longer a good example of something you can build wity Sky. Restore the flights-app-pixel test and move the assets needed for the test into the tests directory. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a4c83a3c95879e5485f8fe7b5c4b6f23170f1d6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -357 lines) Patch
D sky/benchmarks/framework/city-list.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/benchmarks/framework/flights-app.sky View 1 chunk +0 lines, -24 lines 0 comments Download
D sky/examples/flights/images/ba.jpg View Binary file 0 comments Download
D sky/examples/flights/images/delta.jpg View Binary file 0 comments Download
D sky/examples/flights/images/jetblue.jpg View Binary file 0 comments Download
D sky/examples/flights/images/magnifying-glass.png View Binary file 0 comments Download
D sky/examples/flights/images/menu-disabled.png View Binary file 0 comments Download
D sky/examples/flights/images/menu-enabled.png View Binary file 0 comments Download
D sky/examples/flights/images/menu-pressed.png View Binary file 0 comments Download
D sky/examples/flights/images/menu-white.png View Binary file 0 comments Download
D sky/examples/flights/images/united.jpg View Binary file 0 comments Download
D sky/examples/flights/images/virgin-america.jpg View Binary file 0 comments Download
D sky/examples/flights/index.sky View 1 chunk +0 lines, -290 lines 0 comments Download
A + sky/tests/framework/flights-app-pixels.sky View 15 chunks +62 lines, -14 lines 0 comments Download
A + sky/tests/framework/flights-app-pixels-expected.sky View 1 chunk +1 line, -1 line 0 comments Download
A + sky/tests/framework/resources/ba.jpg View Binary file 0 comments Download
A + sky/tests/framework/resources/delta.jpg View Binary file 0 comments Download
A + sky/tests/framework/resources/jetblue.jpg View Binary file 0 comments Download
A + sky/tests/framework/resources/magnifying-glass.png View Binary file 0 comments Download
A + sky/tests/framework/resources/menu-disabled.png View Binary file 0 comments Download
A + sky/tests/framework/resources/menu-enabled.png View Binary file 0 comments Download
A + sky/tests/framework/resources/menu-pressed.png View Binary file 0 comments Download
A + sky/tests/framework/resources/menu-white.png View Binary file 0 comments Download
A + sky/tests/framework/resources/united.jpg View Binary file 0 comments Download
A + sky/tests/framework/resources/virgin-america.jpg View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 8 months ago (2015-03-26 20:25:50 UTC) #1
ojan
lgtm
5 years, 8 months ago (2015-03-26 20:27:40 UTC) #2
abarth-chromium
5 years, 8 months ago (2015-03-26 20:28:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a4c83a3c95879e5485f8fe7b5c4b6f23170f1d6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698