Support dual licensing under MIT and the University of Illinois/NCSA

Support dual licensing under MIT and the University of Illinois/NCSA
(these are the licenses used by libc++ and libc++abi)

BUG=329819
R=phajdan.jr@chromium.org, phajdan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242046

[Alexander Potapenko, 2013-12-19 09:26:10]

Please take a look.

I suggest having an ad-hoc 'dual license:' clause in the whitelist since there's
only one of them right now.
In the future we can strip the 'dual license:' prefix, split by '|' and check
the list against the whitelist.

[Alexander Potapenko, 2013-12-20 08:01:06]

On 2013/12/19 09:26:10, Alexander Potapenko wrote:
> Please take a look.
> 
> I suggest having an ad-hoc 'dual license:' clause in the whitelist since
there's
> only one of them right now.
> In the future we can strip the 'dual license:' prefix, split by '|' and check
> the list against the whitelist.

Ping?

[Paweł Hajdan Jr., 2013-12-20 08:26:09]

https://codereview.chromium.org/103493008/diff/1/third_party/devscripts/licen...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/103493008/diff/1/third_party/devscripts/licen...
third_party/devscripts/licensecheck.pl:501: $license = "dual license: MIT |
University of Illinois/NCSA Open Source License (BSD like) $license";
There's no need to include "dual license" in the text.

Let's do this: change above regex to only say "the University of Illinois Open
Source License"

Then for this make it match on "under the MIT .* License" (and place it near
existing MIT regex.

Does it make sense?

Please note that indeed I'd prefer a more precise identification, e.g. whether
it's OR or AND between the licenses. However, this regex-based approach is
inherently imprecise anyway, and only serves a secondary role.

At Google we rely primarily on OSPO review. This automated license check is
mostly for other Open Source projects using our codebase.

[Alexander Potapenko, 2013-12-20 08:39:44]

https://codereview.chromium.org/103493008/diff/1/third_party/devscripts/licen...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/103493008/diff/1/third_party/devscripts/licen...
third_party/devscripts/licensecheck.pl:501: $license = "dual license: MIT |
University of Illinois/NCSA Open Source License (BSD like) $license";
On 2013/12/20 08:26:09, Paweł Hajdan Jr. wrote:
> There's no need to include "dual license" in the text.
Removed "dual license". 
> Let's do this: change above regex to only say "the University of Illinois Open
> Source License"
Not sure I understand. Do you mean set $license to "the University of Illinois
Open Source License", or use that string in the regex match 
> Then for this make it match on "under the MIT .* License" (and place it near
> existing MIT regex.
> 
> Does it make sense?

Am I understanding you right (see patch set 2)?
As a result, licensecheck.pl generates the following license for a libc++ file:

'third_party/libc++/trunk/src/hash.cpp' has non-whitelisted license 'University
of Illinois/NCSA Open Source License (BSD like) MIT'

Shall I add this line to checklicenses.py?
Overall, looks like licensecheck.pl simply concatenates the licenses it finds in
the source file, so one has to whitelist their concatenation in exactly the same
order the checks are performed. I'm ok with that, but it's kind of ugly.

[Paweł Hajdan Jr., 2013-12-20 08:51:09]

Yes, adding the line you mentioned to checklicenses.py SGTM.

https://codereview.chromium.org/103493008/diff/20001/third_party/devscripts/l...
File third_party/devscripts/licensecheck.pl (right):

https://codereview.chromium.org/103493008/diff/20001/third_party/devscripts/l...
third_party/devscripts/licensecheck.pl:496: $license = "MIT $license";
Let's do elsif here, and output "MIT/X11 (BSD like)" instead of just "MIT" for
consistency.

[Alexander Potapenko, 2013-12-20 08:55:21]

>
https://codereview.chromium.org/103493008/diff/20001/third_party/devscripts/l...
> third_party/devscripts/licensecheck.pl:496: $license = "MIT $license";
> Let's do elsif here, and output "MIT/X11 (BSD like)" instead of just "MIT" for
> consistency.
Done, but IANAL, so I don't have an idea whether "MIT License" means exactly the
same as "MIT/X11"

[Paweł Hajdan Jr., 2013-12-20 08:56:47]

LGTM with a comment.

https://codereview.chromium.org/103493008/diff/40001/tools/checklicenses/chec...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/103493008/diff/40001/tools/checklicenses/chec...
tools/checklicenses/checklicenses.py:95: # Dual licenses.
nit: No need for that comment. Please just remove it and the empty line.

[Alexander Potapenko, 2013-12-20 08:58:32]

Committed patchset #4 manually as r242046 (presubmit successful).