Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 103493005: Rename View::set_focusable and View::set_accessibility_focusable (Closed)

Created:
7 years ago by mohsen
Modified:
7 years ago
Reviewers:
Ilya Sherman, sky
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, yukishiino+watch_chromium.org, davemoore+watch_chromium.org, markusheintz_, benjhayden+dwatch_chromium.org, Ilya Sherman, yusukes+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, alicet1, aboxhall+watch_chromium.org, stevenjb+watch_chromium.org, nona+watch_chromium.org, kalyank, dyu1, haitaol+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, msw+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, ben+views_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, James Su, plundblad+watch_chromium.org, tfarina, benquan, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, rsimha+watch_chromium.org, ben+ash_chromium.org, dmazzoni+watch_chromium.org
Visibility:
Public.

Description

Rename View::set_focusable and View::set_accessibility_focusable These functions are renamed to SetFocusable and SetAccessibilityFocusable, respectively, as a first step to add some functionality to them later. Later the view should give up focus if it has become unfocusable. BUG=323956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240888

Patch Set 1 #

Patch Set 2 : Added a few missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -152 lines) Patch
M ash/focus_cycler_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shelf/overflow_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/audio/tray_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/actionable_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_header_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/tooltip_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/bubble_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_decoration_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/script_bubble_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/native_widget_win_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_password_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_actions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_button_bar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/message_center/views/padded_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/button/button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/image_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/text_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/link.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/native_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_views.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/tree/tree_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/button_example.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/examples/tree_view_example.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M ui/views/focus/focus_manager_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/views/touchui/touch_editing_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/views/view.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mohsen
Renaming part of https://codereview.chromium.org/108063004/. Please take a look...
7 years ago (2013-12-13 20:20:10 UTC) #1
sky
LGTM
7 years ago (2013-12-13 21:09:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/103493005/20001
7 years ago (2013-12-13 21:10:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=235895
7 years ago (2013-12-14 02:41:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/103493005/20001
7 years ago (2013-12-14 03:18:06 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-16 14:07:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 240888

Powered by Google App Engine
This is Rietveld 408576698