Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: ui/chromeos/network/network_connect.cc

Issue 1034923002: Suppress network configuration UI when third-party VPN times out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/chromeos/network/network_connect.cc
diff --git a/ui/chromeos/network/network_connect.cc b/ui/chromeos/network/network_connect.cc
index 822239150b385343a2b4371ff9486402ab869cb6..142955b8293f87b7f4f84f818838522d87d37697 100644
--- a/ui/chromeos/network/network_connect.cc
+++ b/ui/chromeos/network/network_connect.cc
@@ -142,12 +142,19 @@ void NetworkConnectImpl::HandleUnconfiguredNetwork(
return;
}
- if (network->type() == shill::kTypeWimax ||
- network->type() == shill::kTypeVPN) {
+ if (network->type() == shill::kTypeWimax) {
delegate_->ShowNetworkConfigure(service_path);
return;
}
+ if (network->type() == shill::kTypeVPN) {
+ // Third-party VPNs are supposed to do the UI itself.
stevenjb 2015/03/26 15:38:02 nit: Third-party VPNs handle configuration UI them
+ if (network->vpn_provider_type() != shill::kProviderThirdPartyVpn) {
+ delegate_->ShowNetworkConfigure(service_path);
+ }
stevenjb 2015/03/26 15:38:02 nit: no brackets
+ return;
+ }
+
if (network->type() == shill::kTypeCellular) {
if (network->RequiresActivation()) {
ActivateCellular(service_path);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698