Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1034923002: Suppress network configuration UI when third-party VPN times out (Closed)

Created:
5 years, 9 months ago by emaxx
Modified:
5 years, 9 months ago
Reviewers:
stevenjb, kaliamoorthi
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress network configuration UI when third-party VPN times out BUG=470835 Committed: https://crrev.com/f9f1551951609a9f99ae2272c5a692a402e87a6e Cr-Commit-Position: refs/heads/master@{#322397}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Style fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ui/chromeos/network/network_connect.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
emaxx
5 years, 9 months ago (2015-03-26 13:29:44 UTC) #2
kaliamoorthi
On 2015/03/26 13:29:44, emaxx wrote: LGTM, Lets see what stevenjb@ says.
5 years, 9 months ago (2015-03-26 13:32:57 UTC) #3
stevenjb
lgtm w/ nits https://codereview.chromium.org/1034923002/diff/1/ui/chromeos/network/network_connect.cc File ui/chromeos/network/network_connect.cc (right): https://codereview.chromium.org/1034923002/diff/1/ui/chromeos/network/network_connect.cc#newcode151 ui/chromeos/network/network_connect.cc:151: // Third-party VPNs are supposed to ...
5 years, 9 months ago (2015-03-26 15:38:02 UTC) #5
emaxx
On 2015/03/26 15:38:02, stevenjb wrote: > lgtm w/ nits > > https://codereview.chromium.org/1034923002/diff/1/ui/chromeos/network/network_connect.cc > File ui/chromeos/network/network_connect.cc ...
5 years, 9 months ago (2015-03-26 15:56:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034923002/20001
5 years, 9 months ago (2015-03-26 15:57:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 16:26:57 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 16:27:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9f1551951609a9f99ae2272c5a692a402e87a6e
Cr-Commit-Position: refs/heads/master@{#322397}

Powered by Google App Engine
This is Rietveld 408576698