Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1034893002: device/bluetooth: Add read_mtu as an argument of BluetoothAudioSinkDataAvailable. (Closed)

Created:
5 years, 9 months ago by Miao
Modified:
5 years, 9 months ago
Reviewers:
armansito
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Add read_mtu as an argument of BluetoothAudioSinkDataAvailable. This CL added read_mtu into the signature of BluetoothAudioSink::Observer::BluetoothAudioSinkDataAvailable and modified corresponding tests. BUG=441581 TEST=device_unittests --gtest_filter=*AudioSink* Committed: https://crrev.com/ad8553a80203d8be31fc1cd60a4291883bcb3849 Cr-Commit-Position: refs/heads/master@{#322476}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename constants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M chromeos/dbus/fake_bluetooth_media_transport_client.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_media_transport_client.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_audio_sink.h View 1 chunk +6 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_audio_sink_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_audio_sink_chromeos_unittest.cc View 1 7 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Miao
This CL is ready for review.
5 years, 9 months ago (2015-03-26 06:21:11 UTC) #2
armansito
lgtm with one nit https://codereview.chromium.org/1034893002/diff/1/chromeos/dbus/fake_bluetooth_media_transport_client.h File chromeos/dbus/fake_bluetooth_media_transport_client.h (right): https://codereview.chromium.org/1034893002/diff/1/chromeos/dbus/fake_bluetooth_media_transport_client.h#newcode49 chromeos/dbus/fake_bluetooth_media_transport_client.h:49: static const uint16_t kReadMtu; If ...
5 years, 9 months ago (2015-03-26 20:20:19 UTC) #3
Miao
https://codereview.chromium.org/1034893002/diff/1/chromeos/dbus/fake_bluetooth_media_transport_client.h File chromeos/dbus/fake_bluetooth_media_transport_client.h (right): https://codereview.chromium.org/1034893002/diff/1/chromeos/dbus/fake_bluetooth_media_transport_client.h#newcode49 chromeos/dbus/fake_bluetooth_media_transport_client.h:49: static const uint16_t kReadMtu; On 2015/03/26 20:20:18, armansito wrote: ...
5 years, 9 months ago (2015-03-26 20:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034893002/20001
5 years, 9 months ago (2015-03-26 20:35:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 21:36:50 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 21:37:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad8553a80203d8be31fc1cd60a4291883bcb3849
Cr-Commit-Position: refs/heads/master@{#322476}

Powered by Google App Engine
This is Rietveld 408576698