Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1034873002: Add a subtle reminder that chrome_extensions.js is overwritten. (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 9 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a subtle reminder that chrome_extensions.js is overwritten. Also update from github in the process. Leaves externs currently pending review as parts of Chrome already rely on them. R=tbreisacher@chromium.org,hirono@chromium.org BUG=none Committed: https://crrev.com/b997d1d058fbb5ef0e70c2416e4e9a6d72b74bdf Cr-Commit-Position: refs/heads/master@{#322471}

Patch Set 1 : nit #

Patch Set 2 : fun #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -18 lines) Patch
M third_party/closure_compiler/bump_compiler_version View 1 chunk +18 lines, -1 line 0 comments Download
M third_party/closure_compiler/externs/chrome_extensions.js View 1 17 chunks +190 lines, -16 lines 0 comments Download
M ui/file_manager/image_loader/image_loader.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Beam
5 years, 9 months ago (2015-03-26 00:21:27 UTC) #1
Dan Beam
also TBR=hirono@ for small compile fix in ui/file_manager
5 years, 9 months ago (2015-03-26 00:38:32 UTC) #5
Tyler Breisacher (Chromium)
lgtm
5 years, 9 months ago (2015-03-26 04:17:31 UTC) #6
hirono
On 2015/03/26 04:17:31, Tyler Breisacher (Chromium) wrote: > lgtm lg
5 years, 9 months ago (2015-03-26 13:02:07 UTC) #7
hirono
On 2015/03/26 13:02:07, hirono wrote: > On 2015/03/26 04:17:31, Tyler Breisacher (Chromium) wrote: > > ...
5 years, 9 months ago (2015-03-26 13:02:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034873002/60001
5 years, 9 months ago (2015-03-26 20:32:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 9 months ago (2015-03-26 21:14:35 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 21:15:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b997d1d058fbb5ef0e70c2416e4e9a6d72b74bdf
Cr-Commit-Position: refs/heads/master@{#322471}

Powered by Google App Engine
This is Rietveld 408576698