Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1034863003: Add the SHA-1 deprecation string for Android page info security summary phrase. (Closed)

Created:
5 years, 9 months ago by lgarron
Modified:
5 years, 9 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the SHA-1 deprecation string for Android page info security summary phrase. This string will have an accompanying code change that we hope to have ready in time to merge into Chrome 42 for Android. The string needs to land early so we can kick off the translation process. BUG=469853 Committed: https://crrev.com/9ed27ee0b58b10934556bd27cf6037a8b5c11c50 Cr-Commit-Position: refs/heads/master@{#322291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
lgarron
Miguel, Elisabeth says you offered to review this CL (we're trying to land it soon ...
5 years, 9 months ago (2015-03-26 00:04:13 UTC) #2
lgarron
On 2015/03/26 at 00:04:13, lgarron wrote: > Miguel, Elisabeth says you offered to review this ...
5 years, 9 months ago (2015-03-26 00:10:14 UTC) #3
Miguel Garcia
lgtm I assume that the actual text has been approved by Chrome UX. Please update ...
5 years, 9 months ago (2015-03-26 00:24:59 UTC) #4
lgarron
On 2015/03/26 at 00:24:59, miguelg wrote: > lgtm > > I assume that the actual ...
5 years, 9 months ago (2015-03-26 00:27:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034863003/1
5 years, 9 months ago (2015-03-26 00:27:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 01:31:33 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 01:32:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ed27ee0b58b10934556bd27cf6037a8b5c11c50
Cr-Commit-Position: refs/heads/master@{#322291}

Powered by Google App Engine
This is Rietveld 408576698