Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1034863002: Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" (patchset #1 id:1 of https://codereview.chromium.org/1005873006/) Reason for revert: crbug.com/470459, crbug.com/470464, crbug.com/470503, crbug.com/470504, crbug.com/470505 Original issue's description: > Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable"" > > Reason: All known major bugs were fixed. We'd like to try again. > > > Revert 191098 "Enable HTMLPopupMenu in stable" > > > > Reason: Caused crashes > > > > > Enable HTMLPopupMenu in stable > > > > > > BUG=346582 > > > > > > Review URL: https://codereview.chromium.org/961673005 > > > > TBR=keishi@chromium.org > > > > Review URL: https://codereview.chromium.org/983373002 > > TBR=keishi@chromium.org > BUG=346582 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192407 TBR=keishi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Revert 191506 "Revert 191098 "Enable HTMLPopupMenu in stable""
5 years, 9 months ago (2015-03-25 22:40:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034863002/1
5 years, 9 months ago (2015-03-25 22:40:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192561
5 years, 9 months ago (2015-03-25 22:41:18 UTC) #3
tkent
5 years, 8 months ago (2015-04-02 03:31:53 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1055703003/ by tkent@chromium.org.

The reason for reverting is: Major bugs were fixed..

Powered by Google App Engine
This is Rietveld 408576698