Issue 1034823002: QUIC - minor changes found while merging with the internal source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1034823002: QUIC - minor changes found while merging with the internal source. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0324

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC - minor changes found while merging with the internal source. + Formatting changes found while merging. + Added private: to MockAckNotifierDelegate class. Merge internal change: 89527377 R=rch@chromium.org Committed: https://crrev.com/15d265ad49498885aba400ff05285642c925845d Cr-Commit-Position: refs/heads/master@{#322287}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -7 lines)			Patch
M	net/quic/quic_time_wait_list_manager.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034823002/1

5 years, 9 months ago (2015-03-26 00:13:49 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-26 01:14:52 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/15d265ad49498885aba400ff05285642c925845d
Cr-Commit-Position: refs/heads/master@{#322287}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages