Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1034813003: DirectWrite doesn't support Bitmap/Vector fonts and Adobe Type 1 fonts. (Closed)

Created:
5 years, 9 months ago by Shrikant Kelkar
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DirectWrite doesn't support Bitmap/Vector fonts and Adobe Type 1 fonts. With this CL, we ignore font files with .fon/.pfm/.pfb extensions while building our custom font collection. MSDN Ref: http://goo.gl/TfCOA BUG=439571 R=cpu@chromium.org,scottmg@chromium.org Committed: https://crrev.com/b8dabc6ecd380bd3f64a374e9c02f077916d44d8 Cr-Commit-Position: refs/heads/master@{#322470}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/common/dwrite_font_platform_win.cc View 2 chunks +18 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Shrikant Kelkar
5 years, 9 months ago (2015-03-26 00:32:38 UTC) #1
scottmg
lgtm https://codereview.chromium.org/1034813003/diff/1/content/common/dwrite_font_platform_win.cc File content/common/dwrite_font_platform_win.cc (right): https://codereview.chromium.org/1034813003/diff/1/content/common/dwrite_font_platform_win.cc#newcode750 content/common/dwrite_font_platform_win.cc:750: FILE_PATH_LITERAL(".FON"), // Bitmap or vector huh! I didn't ...
5 years, 9 months ago (2015-03-26 01:26:54 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-26 20:10:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034813003/1
5 years, 9 months ago (2015-03-26 20:11:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 21:13:57 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 21:15:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8dabc6ecd380bd3f64a374e9c02f077916d44d8
Cr-Commit-Position: refs/heads/master@{#322470}

Powered by Google App Engine
This is Rietveld 408576698