Issue 1034793002: SkPDF: merge skdocument_pdf and skpdfdocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1034793002: SkPDF: merge skdocument_pdf and skpdfdocument (Closed)

Created:
5 years, 9 months ago by hal.canary

Modified:
5 years, 9 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -244 lines)			Patch
M	gyp/pdf.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/doc/SkDocument_PDF.cpp	View	4 chunks	+188 lines, -7 lines	0 comments	Download
D	src/pdf/SkPDFDocument.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	src/pdf/SkPDFDocument.cpp	View	1 chunk	+0 lines, -194 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034793002/1

5 years, 9 months ago (2015-03-25 18:36:14 UTC) #2

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 9 months ago (2015-03-25 18:36:15 UTC) #3

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 19:15:08 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a43b41538ad6af0f2b7742b4ade8265d344b9d64