Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1034763002: Fix test tolerance for fixed-point line layout. (Closed)

Created:
5 years, 9 months ago by szager1
Modified:
5 years, 9 months ago
Reviewers:
dsinclair, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix test tolerance for fixed-point line layout. Because individual text measurements are rounded to LayoutUnit's, this test must allow for a cumulative rounding error of one LayoutUnit per measured character. BUG=321237 R=eae@chromium.org,dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192587

Patch Set 1 #

Patch Set 2 : Fix TextExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/text/text-rect-precision.html View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
szager1
5 years, 9 months ago (2015-03-25 18:06:54 UTC) #1
eae
LGTM
5 years, 9 months ago (2015-03-25 18:15:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034763002/1
5 years, 9 months ago (2015-03-25 19:56:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/56513)
5 years, 9 months ago (2015-03-25 23:13:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034763002/20001
5 years, 9 months ago (2015-03-25 23:50:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/56547)
5 years, 9 months ago (2015-03-26 03:45:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034763002/20001
5 years, 9 months ago (2015-03-26 06:02:31 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 07:15:57 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192587

Powered by Google App Engine
This is Rietveld 408576698