Issue 1034753002: Revert of Re-enable ChannelMojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1034753002: Revert of Re-enable ChannelMojo (Closed)

Created:
5 years, 9 months ago by Hajime Morrita

Modified:
5 years, 9 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Re-enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/1021393002/) Reason for revert: This depends on https://codereview.chromium.org/1023043002, which was reverted. Original issue's description: > Re-enable ChannelMojo > > It was disabled due to crbug.com/466814 that is now fixed. > It's time to turn it on again. > > R=viettrungluu@chromium.org > BUG=466814, 377980 > > Committed: https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643 > Cr-Commit-Position: refs/heads/master@{#322092} TBR=viettrungluu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466814, 377980 Committed: https://crrev.com/ab68be76b53c10e7aac00e0ed6f2018c72e6af88 Cr-Commit-Position: refs/heads/master@{#322183}

Patch Set 1 #

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ipc/mojo/ipc_channel_mojo.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034753002/1

5 years, 9 months ago (2015-03-25 17:18:02 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-25 17:19:02 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ab68be76b53c10e7aac00e0ed6f2018c72e6af88
Cr-Commit-Position: refs/heads/master@{#322183}

Expand Messages | Collapse Messages