Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1034733004: Debugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents) (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
jvanverth1, Jvsquare
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Debugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents) Displaying the offset into an SkPicture hasn't worked for a while so this CL deletes the feature. When "Save Layer" was renamed to "SaveLayer" the code that computes the indent in the list view was broken. This CL patches the problem. Committed: https://skia.googlesource.com/skia/+/546db46a76ad5f7485cebeb27efaf8b4806fa914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -57 lines) Patch
M debugger/QT/SkDebuggerGUI.h View 2 chunks +0 lines, -6 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 7 chunks +14 lines, -17 lines 0 comments Download
M debugger/QT/SkListWidget.h View 2 chunks +1 line, -14 lines 0 comments Download
M debugger/QT/SkListWidget.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
robertphillips
5 years, 9 months ago (2015-03-26 14:59:36 UTC) #2
Jvsquare
lgtm
5 years, 9 months ago (2015-03-26 16:14:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034733004/1
5 years, 9 months ago (2015-03-26 16:20:46 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-26 16:20:47 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-26 16:54:56 UTC) #8
jvanverth1
lgtm
5 years, 9 months ago (2015-03-26 17:04:44 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 17:08:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/546db46a76ad5f7485cebeb27efaf8b4806fa914

Powered by Google App Engine
This is Rietveld 408576698