src/core/SkCanvas.cpp - Issue 1034733002: Implement approx-match support in image filter saveLayer() offscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 1034733002: Implement approx-match support in image filter saveLayer() offscreen. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index 8426f090ec5949653ab516ffca3f7d33a317c338..5310c9f7d5254e03b18c32fb752e7ed745d16a5a 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -936,14 +936,6 @@ void SkCanvas::internalSaveLayer(const SkRect* bounds, const SkPaint* paint, Sav

}

SkBaseDevice::TileUsage usage = SkBaseDevice::kNever_TileUsage;

-#if 1

- // this seems needed for current GMs, but makes us draw slower on the GPU

- // Related to https://code.google.com/p/skia/issues/detail?id=3519 ?

- //

- if (paint && paint->getImageFilter()) {

- usage = SkBaseDevice::kPossible_TileUsage;

- }

-#endif

device = device->onCreateDevice(SkBaseDevice::CreateInfo(info, usage, geo), paint);

if (NULL == device) {

SkErrorInternals::SetError( kInternalError_SkError,

« no previous file with comments | « no previous file | src/effects/SkMagnifierImageFilter.cpp » ('j') | src/effects/SkMagnifierImageFilter.cpp » ('J')