Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: Source/modules/webdatabase/SQLTransactionBackendSync.cpp

Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix RefPtr/OwnPtr transition gcc errors Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLTransactionBackendSync.cpp
diff --git a/Source/modules/webdatabase/SQLTransactionBackendSync.cpp b/Source/modules/webdatabase/SQLTransactionBackendSync.cpp
index dab2c23d28ff01ceb441fa1630a06374978fd6cb..8ea3155402940613495dafc50fe0143b61a669f1 100644
--- a/Source/modules/webdatabase/SQLTransactionBackendSync.cpp
+++ b/Source/modules/webdatabase/SQLTransactionBackendSync.cpp
@@ -51,7 +51,7 @@
namespace WebCore {
-SQLTransactionBackendSync::SQLTransactionBackendSync(DatabaseSync* db, PassRefPtr<SQLTransactionSyncCallback> callback, bool readOnly)
+SQLTransactionBackendSync::SQLTransactionBackendSync(DatabaseSync* db, PassOwnPtr<SQLTransactionSyncCallback> callback, bool readOnly)
: m_database(db)
, m_callback(callback)
, m_readOnly(readOnly)
@@ -183,12 +183,12 @@ void SQLTransactionBackendSync::execute(ExceptionState& exceptionState)
if (!m_database->opened() || (m_callback && !m_callback->handleEvent(SQLTransactionSync::from(this)))) {
if (m_database->lastErrorMessage().isEmpty())
m_database->setLastErrorMessage("failed to execute transaction callback");
- m_callback = 0;
+ m_callback.clear();
exceptionState.throwDOMException(UnknownError, SQLError::unknownErrorMessage);
return;
}
- m_callback = 0;
+ m_callback.clear();
}
void SQLTransactionBackendSync::commit(ExceptionState& exceptionState)
« no previous file with comments | « Source/modules/webdatabase/SQLTransactionBackendSync.h ('k') | Source/modules/webdatabase/SQLTransactionCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698