Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: Source/modules/webdatabase/DatabaseSync.h

Issue 103473002: Manage WebSQL callbacks with OwnPtr instead of refcounting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/DatabaseSync.h
diff --git a/Source/modules/webdatabase/DatabaseSync.h b/Source/modules/webdatabase/DatabaseSync.h
index b8e1a985292d5c7c34ffcbfff781942f6fc9c910..64551d24df6ac360cfb208c54baccd6109aee557 100644
--- a/Source/modules/webdatabase/DatabaseSync.h
+++ b/Source/modules/webdatabase/DatabaseSync.h
@@ -55,9 +55,9 @@ class DatabaseSync : public DatabaseBase, public DatabaseBackendSync, public Scr
public:
virtual ~DatabaseSync();
- void changeVersion(const String& oldVersion, const String& newVersion, PassRefPtr<SQLTransactionSyncCallback>, ExceptionState&);
- void transaction(PassRefPtr<SQLTransactionSyncCallback>, ExceptionState&);
- void readTransaction(PassRefPtr<SQLTransactionSyncCallback>, ExceptionState&);
+ void changeVersion(const String& oldVersion, const String& newVersion, PassOwnPtr<SQLTransactionSyncCallback>, ExceptionState&);
+ void transaction(PassOwnPtr<SQLTransactionSyncCallback>, ExceptionState&);
+ void readTransaction(PassOwnPtr<SQLTransactionSyncCallback>, ExceptionState&);
virtual void closeImmediately();
@@ -78,7 +78,7 @@ private:
PassRefPtr<DatabaseBackendSync> backend();
static PassRefPtr<DatabaseSync> create(ExecutionContext*, PassRefPtr<DatabaseBackendBase>);
- void runTransaction(PassRefPtr<SQLTransactionSyncCallback>, bool readOnly, ExceptionState&);
+ void runTransaction(PassOwnPtr<SQLTransactionSyncCallback>, bool readOnly, ExceptionState&);
void rollbackTransaction(PassRefPtr<SQLTransactionSync>);
String m_lastErrorMessage;

Powered by Google App Engine
This is Rietveld 408576698