Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1034723002: nacl_loader_unittests should be a test target. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
CC:
chromium-reviews, brettw, Dirk Pranke, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nacl_loader_unittests should be a test target. Tested with the following command lines on Linux: $ gn gen out-gn --args=enable_nacl=true $ ninja -C out-gn nacl_loader_unittests Note: There are still many link errors with this target. They will be addressed in followup patches. BUG=432959 TEST=see above R=bradn@google.com,dpranke@chromium.org TBR=bradnelson@chromium.org Committed: https://crrev.com/544064febdf079ec4d2f63548b0c80c17dc93b6f Cr-Commit-Position: refs/heads/master@{#322365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/nacl/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tfarina
PTAL
5 years, 9 months ago (2015-03-25 15:30:15 UTC) #1
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-25 16:35:21 UTC) #3
bradn
lgtm
5 years, 9 months ago (2015-03-25 17:08:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034723002/1
5 years, 9 months ago (2015-03-25 20:02:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51884)
5 years, 9 months ago (2015-03-25 20:09:37 UTC) #9
tfarina
On Wednesday, March 25, 2015, <commit-bot@chromium.org> wrote: > Try jobs failed on following builders: > ...
5 years, 9 months ago (2015-03-25 20:19:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034723002/1
5 years, 9 months ago (2015-03-26 12:12:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 12:15:18 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 12:15:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/544064febdf079ec4d2f63548b0c80c17dc93b6f
Cr-Commit-Position: refs/heads/master@{#322365}

Powered by Google App Engine
This is Rietveld 408576698