Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6663)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.h

Issue 1034693003: [DevTools] Simplify choice of UMA on remote inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/device/devtools_android_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/devtools_android_bridge.h
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.h b/chrome/browser/devtools/device/devtools_android_bridge.h
index 381984ec5193fe9f887d5a13339ff637ec61caee..bb05d2abe0d325d2b6bc8046e60cae8b48bf02e4 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.h
+++ b/chrome/browser/devtools/device/devtools_android_bridge.h
@@ -69,21 +69,17 @@ class DevToolsAndroidBridge : public KeyedService {
const std::string& serial() { return browser_id_.first; }
const std::string& socket() { return browser_id_.second; }
const std::string& frontend_url() { return frontend_url_; }
- bool is_web_view() { return is_web_view_; }
private:
friend class base::RefCounted<RemotePage>;
friend class DevToolsAndroidBridge;
- RemotePage(const BrowserId& browser_id,
- const base::DictionaryValue& dict,
- bool is_web_view);
+ RemotePage(const BrowserId& browser_id, const base::DictionaryValue& dict);
virtual ~RemotePage();
BrowserId browser_id_;
std::string frontend_url_;
- bool is_web_view_;
scoped_ptr<base::DictionaryValue> dict_;
DISALLOW_COPY_AND_ASSIGN(RemotePage);
@@ -102,7 +98,6 @@ class DevToolsAndroidBridge : public KeyedService {
const RemotePages& pages() { return pages_; }
bool IsChrome();
- bool IsWebView();
std::string GetId();
typedef std::vector<int> ParsedVersion;
« no previous file with comments | « no previous file | chrome/browser/devtools/device/devtools_android_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698