[DevTools] Simplify choice of UMA on remote inspect

[DevTools] Simplify choice of UMA on remote inspect

BUG=

Committed: https://crrev.com/0b6a6681d4051ac2356e500dfaf8b3838dc44e73
Cr-Commit-Position: refs/heads/master@{#322358}

[vkuzkokov, 2015-03-25 15:19:27]

Patchset #1 (id:1) has been deleted

[vkuzkokov, 2015-03-25 15:19:48]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-03-25 16:11:50]

https://codereview.chromium.org/1034693003/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/1034693003/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:604: return type_ ==
AndroidDeviceManager::BrowserInfo::kTypeChrome;
Let's remove |type| everywhere, move GetBrowserType() function right here, and
call it when needed.

[vkuzkokov, 2015-03-26 09:46:31]

https://codereview.chromium.org/1034693003/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/1034693003/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:604: return type_ ==
AndroidDeviceManager::BrowserInfo::kTypeChrome;
On 2015/03/25 16:11:50, dgozman wrote:
> Let's remove |type| everywhere, move GetBrowserType() function right here, and
> call it when needed.

Moving GetBrowserType here would require splitting kBrowserDescriptors between
here and android_device_info_query.cc which seems unnecessary as the part we're
moving here we were going to move further to javascript anyway.

[dgozman, 2015-03-26 10:21:37]

lgtm

[vkuzkokov, 2015-03-26 10:55:53]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2015-03-26 10:56:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1034693003/20001

[commit-bot: I haz the power, 2015-03-26 10:58:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 10:58:48]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[vkuzkokov, 2015-03-26 11:02:19]

The CQ bit was checked by vkuzkokov@chromium.org

[vkuzkokov, 2015-03-26 11:02:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1034693003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-03-26 11:02:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1034693003/40001

[commit-bot: I haz the power, 2015-03-26 11:50:08]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-26 11:50:57]

Patchset 2 (id:??) landed as
https://crrev.com/0b6a6681d4051ac2356e500dfaf8b3838dc44e73
Cr-Commit-Position: refs/heads/master@{#322358}