Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1034663003: Added FBO Invalidation workaround for Nexus 6. (Closed)

Created:
5 years, 9 months ago by David Yen
Modified:
5 years, 9 months ago
Reviewers:
no sievers, vmiura
CC:
chromium-reviews, piman+watch_chromium.org, bsalomon_chromium, Justin Novosad, Ken Russell (switch to Gerrit), vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added FBO Invalidation workaround for Nexus 6. We have run into a driver issue where after we invalidate a Frame Buffer Object it gets into a state where it will randomly drop draw calls and/or texture copies. I have added a workaround for this issue by skipping frame buffer invalidations on Adreno 420s. This is valid because invalidations set the frame buffer to be in an undefined state so skipping them is technically okay, however we may lose optimizations that could happen at the driver level for operations being performed on an undefined FBO. R=sievers@chromium.org, vmiura@chromium.org BUG=443060 Committed: https://crrev.com/5f38cadcf0dd0f324f8281d9bdd8a6ed9448a9a9 Cr-Commit-Position: refs/heads/master@{#322403}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Applied vmiura's fixes. #

Total comments: 2

Patch Set 3 : Added android filter #

Patch Set 4 : Removed extra comma in json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
David Yen
5 years, 9 months ago (2015-03-25 21:39:13 UTC) #1
vmiura
https://codereview.chromium.org/1034663003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1034663003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4495 gpu/command_buffer/service/gles2_cmd_decoder.cc:4495: if (workarounds().disable_fbo_invalidations) { nit: no need for {} brackets. ...
5 years, 9 months ago (2015-03-25 21:43:12 UTC) #2
David Yen
https://codereview.chromium.org/1034663003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1034663003/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4495 gpu/command_buffer/service/gles2_cmd_decoder.cc:4495: if (workarounds().disable_fbo_invalidations) { On 2015/03/25 21:43:11, vmiura wrote: > ...
5 years, 9 months ago (2015-03-25 21:45:27 UTC) #3
vmiura
LGTM with comment. https://codereview.chromium.org/1034663003/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/1034663003/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode1183 gpu/config/gpu_driver_bug_list_json.cc:1183: "cr_bugs": [443060], Maybe add an os ...
5 years, 9 months ago (2015-03-25 23:35:34 UTC) #4
David Yen
https://codereview.chromium.org/1034663003/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/1034663003/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode1183 gpu/config/gpu_driver_bug_list_json.cc:1183: "cr_bugs": [443060], On 2015/03/25 23:35:34, vmiura wrote: > Maybe ...
5 years, 9 months ago (2015-03-25 23:38:48 UTC) #5
no sievers
lgtm
5 years, 9 months ago (2015-03-25 23:54:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034663003/60001
5 years, 9 months ago (2015-03-26 16:55:20 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-26 16:58:51 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 16:59:24 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5f38cadcf0dd0f324f8281d9bdd8a6ed9448a9a9
Cr-Commit-Position: refs/heads/master@{#322403}

Powered by Google App Engine
This is Rietveld 408576698