Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1034603002: Prefix build variables used in separate repos with mojo_ (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
Reviewers:
jamesr, blundell
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge to trunk #

Patch Set 3 : more mojo_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -37 lines) Patch
M build/module_args/mojo.gni View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/mojo.gni View 1 2 1 chunk +12 lines, -10 lines 0 comments Download
M mojo/public/mojo_application.gni View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/tools/BUILD.gn View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/content_handler/public/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/http_server/public/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/navigation/public/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M shell/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
sky
5 years, 9 months ago (2015-03-24 22:23:01 UTC) #1
viettrungluu
I know nothing about any of this. Probably James or Colin would be a better ...
5 years, 9 months ago (2015-03-24 22:32:20 UTC) #2
sky
vtl->jamesr
5 years, 9 months ago (2015-03-24 22:39:31 UTC) #4
sky
+colin
5 years, 9 months ago (2015-03-25 16:17:51 UTC) #6
blundell
https://codereview.chromium.org/1034603002/diff/1/build/module_args/mojo.gni File build/module_args/mojo.gni (right): https://codereview.chromium.org/1034603002/diff/1/build/module_args/mojo.gni#newcode12 build/module_args/mojo.gni:12: build_mojo_shell_from_source = true For consistency, I would change this ...
5 years, 9 months ago (2015-03-26 11:18:31 UTC) #7
sky
https://codereview.chromium.org/1034603002/diff/1/build/module_args/mojo.gni File build/module_args/mojo.gni (right): https://codereview.chromium.org/1034603002/diff/1/build/module_args/mojo.gni#newcode12 build/module_args/mojo.gni:12: build_mojo_shell_from_source = true On 2015/03/26 11:18:31, blundell wrote: > ...
5 years, 9 months ago (2015-03-26 14:15:18 UTC) #8
blundell
lgtm Were you planning on rolling this into Chromium and making the corresponding updates there?
5 years, 9 months ago (2015-03-26 14:19:41 UTC) #9
blundell
On 2015/03/26 14:19:41, blundell wrote: > lgtm > > Were you planning on rolling this ...
5 years, 9 months ago (2015-03-26 14:29:59 UTC) #10
sky
5 years, 9 months ago (2015-03-26 14:30:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
912f52f69dadbe1e3cf9576f26731863770bcfc3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698