Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1034583002: SkPDF refactor skpdfdocument (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF refactor skpdfdocument Most fields removed, made local to emitPDF function (since we never emit twice). Variables made into stack variables or auto-unrefed. we hold devices, not pages. addResourcesToCatalog inlined unused setPage function removed. deprecated getCountOfFontTypes function removed private functions removed BUG=skia:3585 Committed: https://skia.googlesource.com/skia/+/6adf849f4eedd19591ce35129a846209e7e6393b

Patch Set 1 #

Patch Set 2 : SkToS32() 2015-03-24 (Tuesday) 16:54:14 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -246 lines) Patch
M src/pdf/SkPDFDocument.h View 2 chunks +5 lines, -42 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 4 chunks +125 lines, -204 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
hal.canary
5 years, 9 months ago (2015-03-24 20:43:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034583002/1
5 years, 9 months ago (2015-03-24 20:43:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 20:43:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/86) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 9 months ago (2015-03-24 20:47:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034583002/20001
5 years, 9 months ago (2015-03-24 20:54:31 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 20:54:32 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-25 02:54:39 UTC) #12
mtklein
lgtm
5 years, 9 months ago (2015-03-25 12:06:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034583002/20001
5 years, 9 months ago (2015-03-25 12:06:20 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 12:06:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6adf849f4eedd19591ce35129a846209e7e6393b

Powered by Google App Engine
This is Rietveld 408576698