[Extension API Extern Generation] Fix array, choices specification

[Extension API Extern Generation] Fix array specification

Instead of simply outputting "Array", we now output the type of the array
(e.g., Array<number> or Array<MyCustomType>). Additionally, arrays should not
be nullable.

Choices (e.g., (DOMString or number) in an .idl) are also now supported.

BUG=461039
Committed: https://crrev.com/bde8f5743aa2891cd8f9578c281e50bfd05ca640
Cr-Commit-Position: refs/heads/master@{#322110}

[Devlin, 2015-03-24 22:40:35]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-03-24 22:40:39]

Patchset #1 (id:20001) has been deleted

[Devlin, 2015-03-24 22:41:22]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org, tbreisacher@chromium.org

[Devlin, 2015-03-24 22:41:22]

Next! :)

[Dan Beam, 2015-03-24 22:44:45]

what about any[]?

[Tyler Breisacher (Chromium), 2015-03-24 22:45:03]

I didn't really look at the code, just the test, so I'll let Dan officially LG.
In general, feel free to submit these without waiting for me unless you have a
specific question about the compiler's JSDoc parsing or something like that.

https://codereview.chromium.org/1034553003/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/js_externs_generator_test.py (right):

https://codereview.chromium.org/1034553003/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/js_externs_generator_test.py:91: *   enumArr:
!Array<chrome.fakeApi.Greek>,
should this be !Array<!chrome.fakeApi.Greek> ?

https://codereview.chromium.org/1034553003/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/js_externs_generator_test.py:94: *   choice:
(string|chrome.fakeApi.Greek|!Array<number>)
(string|!chrome.fakeApi.Greek|!Array<number>) ?

[Devlin, 2015-03-24 23:05:59]

Patchset #2 (id:60001) has been deleted

[Devlin, 2015-03-24 23:10:22]

On 2015/03/24 22:44:45, Dan Beam wrote:
> what about any[]?

Before, any would fall into the '?' case.  I suppose it might make more sense
for it to be '*'.  Adjusted.

[Devlin, 2015-03-24 23:10:37]

https://codereview.chromium.org/1034553003/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/js_externs_generator_test.py (right):

https://codereview.chromium.org/1034553003/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/js_externs_generator_test.py:91: *   enumArr:
!Array<chrome.fakeApi.Greek>,
On 2015/03/24 22:45:03, Tyler Breisacher (Chromium) wrote:
> should this be !Array<!chrome.fakeApi.Greek> ?

Yes, I suppose that makes sense, as long as we maintain the ability for, e.g.,
optional enums (which we have, and has been added to the test).

https://codereview.chromium.org/1034553003/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/js_externs_generator_test.py:94: *   choice:
(string|chrome.fakeApi.Greek|!Array<number>)
On 2015/03/24 22:45:03, Tyler Breisacher (Chromium) wrote:
> (string|!chrome.fakeApi.Greek|!Array<number>) ?

Done.

[Dan Beam, 2015-03-25 00:08:18]

lgtm though handling just Array<> (instead of always !Array<>) might be useful
as well if this ever happens

[Devlin, 2015-03-25 00:17:23]

On 2015/03/25 00:08:18, Dan Beam wrote:
> lgtm though handling just Array<> (instead of always !Array<>) might be useful
> as well if this ever happens

I think it's probably okay - the standard in the definition files is to make
things optional if they aren't present (e.g., DOMString? maybePresent), and so
we can have things like Foo[]? maybeArray (which is tested here).  Since we have
this option for the case of when an array is intended to be maybe-present, I'm
not sure we need to also have a nullable array.

[Devlin, 2015-03-25 01:51:04]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-03-25 01:51:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1034553003/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-25 01:51:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1034553003/100001

[commit-bot: I haz the power, 2015-03-25 01:57:56]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-03-25 01:58:33]

Patchset 3 (id:??) landed as
https://crrev.com/bde8f5743aa2891cd8f9578c281e50bfd05ca640
Cr-Commit-Position: refs/heads/master@{#322110}