Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1034553002: Fixing debug GN build. (Closed)

Created:
5 years, 9 months ago by bradn
Modified:
5 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing debug GN build. Gate out ICU initialization for OS_NACL, as it calls other code that is not built for nacl. Undetected in gyp build since we always build the nacl irt as release with gc-sections. Stop building the ppb_var_deprecated_proxy as it's only used in the trusted build for flash. Undetected in gyp build since we always build the nacl irt as release with gc-sections. BUG=https://code.google.com/p/chromium/issues/detail?id=462791 TEST=trybots R=dmichael@chromium.org,dpranke@chromium.org Committed: https://crrev.com/961324d2110aaba0302b72ec88a78e7c36e4dfdd Cr-Commit-Position: refs/heads/master@{#322070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M base/i18n/icu_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/icu_util.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bradn
5 years, 9 months ago (2015-03-24 17:48:01 UTC) #1
dmichael (off chromium)
lgtm
5 years, 9 months ago (2015-03-24 17:51:27 UTC) #2
rvargas (doing something else)
lgtm
5 years, 9 months ago (2015-03-24 18:29:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034553002/1
5 years, 9 months ago (2015-03-24 18:30:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 21:03:12 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 21:04:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/961324d2110aaba0302b72ec88a78e7c36e4dfdd
Cr-Commit-Position: refs/heads/master@{#322070}

Powered by Google App Engine
This is Rietveld 408576698