Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1034543002: Revert of Update V8 to version 4.3.51. (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 4.3.51. (patchset #1 id:1 of https://codereview.chromium.org/1033603003/) Reason for revert: Broke several blink tests related to line/column positions. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/45881 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=window-onerror-1 Original issue's description: > Update V8 to version 4.3.51. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/230d131d..19b29c5c > > Please follow these instructions for assigning/CC'ing issues: > https://code.google.com/p/v8-wiki/wiki/TriagingIssues > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/814cfc622787295a0c27fa1a8c55c95685ac76f4 > Cr-Commit-Position: refs/heads/master@{#321994} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/df1c1cb25c28cf5c484700b4ecf499f44d21dce8 Cr-Commit-Position: refs/heads/master@{#322020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
Created Revert of Update V8 to version 4.3.51.
5 years, 9 months ago (2015-03-24 17:18:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034543002/1
5 years, 9 months ago (2015-03-24 17:18:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 17:19:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df1c1cb25c28cf5c484700b4ecf499f44d21dce8 Cr-Commit-Position: refs/heads/master@{#322020}
5 years, 9 months ago (2015-03-24 17:20:31 UTC) #4
Michael Achenbach
5 years, 9 months ago (2015-03-24 18:23:05 UTC) #5
Message was sent while issue was closed.
Sorry for the manual roll. These blink errors were hidden by another one on our
upstream bots. I try again with a version that includes a revert of the
culprit...

Powered by Google App Engine
This is Rietveld 408576698