Show detailed report on upgrade.

sdk/lib/_internal/pub/test/test_pub.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Test infrastructure for testing pub. Unlike typical unit tests, most pub
 /// tests are integration tests that stage some stuff on the file system, run
 /// pub, and then validate the results. This library provides an API to build
 /// tests like that.
 library test_pub;
 
@@ skipping 245 matching lines @@
 /// The path of the packages directory in the mock app used for tests. Relative
 /// to the sandbox directory.
 final String packagesPath = "$appPath/packages";
 
 /// Set to true when the current batch of scheduled events should be aborted.
 bool _abortScheduled = false;
 
 /// Enum identifying a pub command that can be run with a well-defined success
 /// output.
 class RunCommand {
-  static final get = new RunCommand('get', 'Got dependencies!');
-  static final upgrade = new RunCommand('upgrade', 'Dependencies upgraded!');
+  static final get = new RunCommand('get', r'Got dependencies!$');
+  static final upgrade = new RunCommand('upgrade',
+      r'(No dependencies changed\.|Changed \d+ dependenc(y|ies)!)$');
 
   final String name;
   final RegExp success;
-  RunCommand(this.name, String message)
-      : success = new RegExp("$message\$");
+  RunCommand(this.name, String pattern)

[nweiz, 2013/12/11 06:48:32]

If you're going to take a pattern, take a Pattern. Taking a string and
converting it to a RegExp implicitly is confusing.

[Bob Nystrom, 2013/12/11 22:36:59]

Done.

+      : success = new RegExp(pattern);
 }
 
 /// Many tests validate behavior that is the same between pub get and
 /// upgrade have the same behavior. Instead of duplicating those tests, this
 /// takes a callback that defines get/upgrade agnostic tests and runs them
 /// with both commands.
 void forBothPubGetAndUpgrade(void callback(RunCommand command)) {
   group(RunCommand.get.name, () => callback(RunCommand.get));
   group(RunCommand.upgrade.name, () => callback(RunCommand.upgrade));
 }
 
 /// Schedules an invocation of pub [command] and validates that it completes
 /// in an expected way.
 ///
 /// By default, this validates that the command completes successfully and
 /// understands the normal output of a successful pub command. If [warning] is
 /// given, it expects the command to complete successfully *and* print
 /// [warning] to stderr. If [error] is given, it expects the command to *only*
 /// print [error] to stderr.
 // TODO(rnystrom): Clean up other tests to call this when possible.
-void pubCommand(RunCommand command, {Iterable<String> args, Pattern error,
-    Pattern warning}) {
+void pubCommand(RunCommand command,
+    {Iterable<String> args, Pattern output, Pattern error, Pattern warning}) {
   if (error != null && warning != null) {
     throw new ArgumentError("Cannot pass both 'error' and 'warning'.");
   }
 
   var allArgs = [command.name];
   if (args != null) allArgs.addAll(args);
 
-  var output = command.success;
+  if (output == null) output = command.success;
 
   var exitCode = null;
   if (error != null) exitCode = 1;
 
   // No success output on an error.
   if (error != null) output = null;
   if (warning != null) error = warning;
 
   schedulePub(args: allArgs, output: output, error: error, exitCode: exitCode);
 }
 
 void pubGet({Iterable<String> args, Pattern error,
     Pattern warning}) {
   pubCommand(RunCommand.get, args: args, error: error, warning: warning);
 }
 
-void pubUpgrade({Iterable<String> args, Pattern error,
+void pubUpgrade({Iterable<String> args, Pattern output, Pattern error,
     Pattern warning}) {
-  pubCommand(RunCommand.upgrade, args: args, error: error, warning: warning);
+  pubCommand(RunCommand.upgrade, args: args, output: output, error: error,
+      warning: warning);
 }
 
 /// Defines an integration test. The [body] should schedule a series of
 /// operations which will be run asynchronously.
 void integration(String description, void body()) =>
   _integration(description, body, test);
 
 /// Like [integration], but causes only this test to run.
 void solo_integration(String description, void body()) =>
   _integration(description, body, solo_test);
@@ skipping 525 matching lines @@
   bool matches(item, Map matchState) {
     if (item is! Pair) return false;
     return _firstMatcher.matches(item.first, matchState) &&
         _lastMatcher.matches(item.last, matchState);
   }
 
   Description describe(Description description) {
     description.addAll("(", ", ", ")", [_firstMatcher, _lastMatcher]);
   }
 }