Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1034523002: Test for access checks on super assignments. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test for access checks on super assignments. R=verwaest@chromium.org BUG=chromium:470113 LOG=N Committed: https://crrev.com/1f6c46879bf184cdd8614e7b64b2d7ee769e2ae6 Cr-Commit-Position: refs/heads/master@{#27438}

Patch Set 1 #

Patch Set 2 : Rebase + typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M test/cctest/test-api.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dmitry Lomov (no reviews)
ptal
5 years, 9 months ago (2015-03-24 16:22:41 UTC) #1
Dmitry Lomov (no reviews)
ping
5 years, 9 months ago (2015-03-25 11:30:02 UTC) #2
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-25 12:26:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034523002/20001
5 years, 9 months ago (2015-03-25 12:32:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 12:52:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 12:52:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f6c46879bf184cdd8614e7b64b2d7ee769e2ae6
Cr-Commit-Position: refs/heads/master@{#27438}

Powered by Google App Engine
This is Rietveld 408576698