Issue 1034513002: fix attribute lookup for all can read indexed interceptors

Issue 1034513002: fix attribute lookup for all can read indexed interceptors (Closed)

Created:
5 years, 9 months ago by dcarney

Modified:
5 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

fix attribute lookup for all can read indexed interceptors R=verwaest@chromium.org BUG= Committed: https://crrev.com/a3b7c8320ef169188efcd0a7c4c3ad5f4c380681 Cr-Commit-Position: refs/heads/master@{#27420}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
	M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/cctest/test-api-interceptors.cc	View	1	2 chunks	+26 lines, -6 lines	0 comments	Download

Total messages: 7 (3 generated)

Toon Verwaest

lgtm, just add a comment that element access is iterating too far behind the interceptor.

5 years, 9 months ago (2015-03-24 15:09:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034513002/20001

5 years, 9 months ago (2015-03-24 15:10:43 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-24 16:10:20 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a3b7c8320ef169188efcd0a7c4c3ad5f4c380681
Cr-Commit-Position: refs/heads/master@{#27420}