Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Unified Diff: Source/modules/accessibility/AXListBoxOption.h

Issue 1034493005: Fire AX notifications on list box options. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menu_list_more
Patch Set: Update expectations for other test that failed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXListBox.cpp ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXListBoxOption.h
diff --git a/Source/modules/accessibility/AXListBoxOption.h b/Source/modules/accessibility/AXListBoxOption.h
index 69f0917fc5019877889fe87f56a4ad84c6043183..9ce33ad458e292784138d36b3c907895a232f3ec 100644
--- a/Source/modules/accessibility/AXListBoxOption.h
+++ b/Source/modules/accessibility/AXListBoxOption.h
@@ -47,6 +47,7 @@ public:
static PassRefPtr<AXListBoxOption> create(LayoutObject*, AXObjectCacheImpl*);
virtual ~AXListBoxOption();
+ virtual bool isAXListBoxOption() const override { return true; }
virtual AccessibilityRole roleValue() const override;
virtual bool isSelected() const override;
virtual bool isEnabled() const override;
@@ -57,7 +58,6 @@ public:
virtual String title(TextUnderElementMode) const override { return String(); }
private:
- virtual bool isListBoxOption() const override { return true; }
virtual bool canHaveChildren() const override { return false; }
virtual bool computeAccessibilityIsIgnored() const override;
@@ -66,7 +66,7 @@ private:
AXObject* listBoxOptionAXObject(HTMLElement*) const;
};
-DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isListBoxOption());
+DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isAXListBoxOption());
} // namespace blink
« no previous file with comments | « Source/modules/accessibility/AXListBox.cpp ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698