Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 1034493005: Fire AX notifications on list box options. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menu_list_more
Patch Set: Update expectations for other test that failed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/modules/accessibility/AXListBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index d8eb4c116e4683ed3e38761b208b55c339c7dacf..2a5d6c9253a03401aba4172c36a807ce9f003f5c 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -730,7 +730,7 @@ void HTMLSelectElement::scrollToSelection()
return;
scrollToIndex(activeSelectionEndListIndex());
if (AXObjectCache* cache = document().existingAXObjectCache())
- cache->selectedChildrenChanged(this);
+ cache->listboxActiveIndexChanged(this);
}
void HTMLSelectElement::setOptionsChangedOnRenderer()
@@ -970,9 +970,6 @@ void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)
if (LayoutObject* renderer = this->layoutObject()) {
if (usesMenuList()) {
toLayoutMenuList(renderer)->didSetSelectedIndex(listIndex);
- } else if (renderer->isListBox()) {
- if (AXObjectCache* cache = document().existingAXObjectCache())
- cache->selectedChildrenChanged(this);
}
}
}
« no previous file with comments | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/modules/accessibility/AXListBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698