Source/core/dom/AXObjectCache.h - Issue 1034493005: Fire AX notifications on list box options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/AXObjectCache.h

Issue 1034493005: Fire AX notifications on list box options. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menu_list_more

Patch Set: Update expectations for other test that failed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/AXObjectCache.h

diff --git a/Source/core/dom/AXObjectCache.h b/Source/core/dom/AXObjectCache.h

index 222ad691bf271ddcb1b42dbfcec4aa55da1d6adb..1685ebeb6f88693886c6dd3d673e552dceca881d 100644

--- a/Source/core/dom/AXObjectCache.h

+++ b/Source/core/dom/AXObjectCache.h

@@ -34,6 +34,8 @@ typedef unsigned AXID;

namespace blink {

class AXObject;

class FrameView;

+class HTMLOptionElement;

+class HTMLSelectElement;

class LayoutMenuList;

class Page;

class Widget;

@@ -83,7 +85,9 @@ public:

virtual void childrenChanged(Node*) = 0;

virtual void childrenChanged(LayoutObject*) = 0;

virtual void checkedStateChanged(Node*) = 0;

- virtual void selectedChildrenChanged(Node*) = 0;

+ virtual void listboxOptionStateChanged(HTMLOptionElement*) = 0;

+ virtual void listboxSelectedChildrenChanged(HTMLSelectElement*) = 0;

+ virtual void listboxActiveIndexChanged(HTMLSelectElement*) = 0;

virtual void remove(LayoutObject*) = 0;

virtual void remove(Node*) = 0;