Files.app: Calculate the hit elements on drag-selection correctly.

Files.app: Calculate the hit elements on drag-selection correctly.

- Specified vertical-align:top, because inline blocks with vertical-align:baseline could insert unexpected vertical spacing for each lines.
- Consider the padding of the grid in getHitElements().

BUG=463042
TEST=manual test

Committed: https://crrev.com/2a2b00ffa76a85f9a6586d19191218edaf429591
Cr-Commit-Position: refs/heads/master@{#322114}

[fukino, 2015-03-24 08:03:09]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2015-03-24 08:03:10]

PTAL. Thanks!

[hirono, 2015-03-24 08:13:06]

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/css/file_manager.css:1024:
vertical-align: top;
just curious: could you explain why is this require?

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:430: x = Math.max(0,
x - this.paddingLeft_);
nit: Can we assign the values to new variables? Using same name for different
meanings may be confusing.

[fukino, 2015-03-24 08:38:02]

Thank you!

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/css/file_manager.css:1024:
vertical-align: top;
On 2015/03/24 08:13:06, hirono wrote:
> just curious: could you explain why is this require?

Added a comment and a brief explanation on CL description.

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:430: x = Math.max(0,
x - this.paddingLeft_);
On 2015/03/24 08:13:06, hirono wrote:
> nit: Can we assign the values to new variables? Using same name for different
> meanings may be confusing.

Done.

[hirono, 2015-03-24 10:59:32]

On 2015/03/24 08:38:02, fukino wrote:
> Thank you!
> 
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/css/file_manager.css (right):
> 
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/css/file_manager.css:1024:
> vertical-align: top;
> On 2015/03/24 08:13:06, hirono wrote:
> > just curious: could you explain why is this require?
> 
> Added a comment and a brief explanation on CL description.
> 
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):
> 
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/js/ui/file_grid.js:430: x =
Math.max(0,
> x - this.paddingLeft_);
> On 2015/03/24 08:13:06, hirono wrote:
> > nit: Can we assign the values to new variables? Using same name for
different
> > meanings may be confusing.
> 
> Done.

lgtm!

[fukino, 2015-03-25 04:07:03]

On 2015/03/24 10:59:32, hirono wrote:
> On 2015/03/24 08:38:02, fukino wrote:
> > Thank you!
> > 
> >
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> > File ui/file_manager/file_manager/foreground/css/file_manager.css (right):
> > 
> >
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> > ui/file_manager/file_manager/foreground/css/file_manager.css:1024:
> > vertical-align: top;
> > On 2015/03/24 08:13:06, hirono wrote:
> > > just curious: could you explain why is this require?
> > 
> > Added a comment and a brief explanation on CL description.
> > 
> >
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> > File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):
> > 
> >
>
https://codereview.chromium.org/1034443002/diff/1/ui/file_manager/file_manage...
> > ui/file_manager/file_manager/foreground/js/ui/file_grid.js:430: x =
> Math.max(0,
> > x - this.paddingLeft_);
> > On 2015/03/24 08:13:06, hirono wrote:
> > > nit: Can we assign the values to new variables? Using same name for
> different
> > > meanings may be confusing.
> > 
> > Done.
> 
> lgtm!

Thanks!

[fukino, 2015-03-25 04:07:10]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2015-03-25 04:08:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1034443002/20001

[commit-bot: I haz the power, 2015-03-25 05:13:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 05:14:07]

Patchset 2 (id:??) landed as
https://crrev.com/2a2b00ffa76a85f9a6586d19191218edaf429591
Cr-Commit-Position: refs/heads/master@{#322114}