LayoutTests/fast/borders/border-hittest-inlineFlowBox.html - Issue 1034433003: Hittest for RootInlineBox/InlineFlowBox should take care of border-radius.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/borders/border-hittest-inlineFlowBox.html

Issue 1034433003: Hittest for RootInlineBox/InlineFlowBox should take care of border-radius. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <style>

	6 body { margin: 2em; }

	7

	8 #test {

	9 background-color: green;

	10 border-radius: 50px;

	11 padding: 1em;

	12 }

	13

	14 #test:hover {
	davve 2015/03/24 13:26:03 You want to keep the hover rule for manual testing You want to keep the hover rule for manual testing? Abhijeet Kandalkar Slow 2015/03/24 14:42:44 Yes, it is for manual testing. Keeping span:hover Show quoted text On 2015/03/24 13:26:03, David Vest wrote: > You want to keep the hover rule for manual testing? Yes, it is for manual testing. Keeping span:hover mangle with <span> inserted by js-test script and produce undesirable visual output.
	15 background-color:red;

	16 }

	17 </style>

	18 </head>

	19 <body>

	20 <span id="test">

	21 <button>dummy</button>

	22 </span>

	23 <br><br><br>

	24 <div id="console"></div>
	davve 2015/03/24 13:26:03 You may drop this element? Would probably require You may drop this element? Would probably require you to regenerate the expected file though... Abhijeet Kandalkar Slow 2015/03/24 14:42:44 Same as above. For better readability during manua Show quoted text On 2015/03/24 13:26:03, David Vest wrote: > You may drop this element? Would probably require you to regenerate the expected > file though... Same as above. For better readability during manual testing.
	25 </body>

	26 <script>

	27 description('If this test passes, area outside is body element.');
	davve 2015/03/24 13:26:03 ... area outside border radius is body element ... ... area outside border radius is body element ... Abhijeet Kandalkar Slow 2015/03/24 14:42:44 Done. Show quoted text On 2015/03/24 13:26:03, David Vest wrote: > ... area outside border radius is body element ... Done.
	28 var offset = 4;

	29 var expectedTarget = document.getElementById('test');

	30 var rect = expectedTarget.getBoundingClientRect();

	31 var element = document.elementFromPoint(rect.right - offset, rect.bottom - offse t);

	32 shouldBe('element.nodeName', '"BODY"');

	33 </script>

	34 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/borders/border-hittest-inlineFlowBox-expected.txt » ('j') | Source/core/layout/line/InlineFlowBox.cpp » ('J')