Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1034403003: Re-enable checking the "child-account-detection" finch flag on Android. (Closed)

Created:
5 years, 8 months ago by knn
Modified:
5 years, 8 months ago
Reviewers:
Marc Treib, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable checking the "child-account-detection" finch flag on Android. This was broken on M42 as it was being called before JNI registration. However that code has been moved since then and it should and is working fine post M42. BUG=467938 Committed: https://crrev.com/11cfb4c7d39135c90941aa13240e83546c75be20 Cr-Commit-Position: refs/heads/master@{#322589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/child_accounts/ChildAccountService.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
knn
PTAL.
5 years, 8 months ago (2015-03-27 14:14:04 UTC) #2
Marc Treib
LGTM, but I don't own this :)
5 years, 8 months ago (2015-03-27 14:25:00 UTC) #3
Yaron
lgtm
5 years, 8 months ago (2015-03-27 15:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034403003/1
5 years, 8 months ago (2015-03-27 15:47:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-27 16:15:41 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 16:16:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11cfb4c7d39135c90941aa13240e83546c75be20
Cr-Commit-Position: refs/heads/master@{#322589}

Powered by Google App Engine
This is Rietveld 408576698