Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 1034393002: Fix speedup of typedarray-length loading in the ICs as well as Crankshaft (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix speedup of typedarray-length loading in the ICs as well as Crankshaft BUG= Committed: https://crrev.com/87eef73234e7e801b41e5a52a8ebc66f2c3bc602 Cr-Commit-Position: refs/heads/master@{#27519}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add test #

Total comments: 1

Patch Set 4 : Add tests #

Patch Set 5 : More tests #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -15 lines) Patch
M src/accessors.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M src/typedarray.js View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/v8natives.js View 1 chunk +5 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-typedarray-length.js View 1 2 3 4 5 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-27 12:21:53 UTC) #2
Dmitry Lomov (no reviews)
lgtm % tests https://codereview.chromium.org/1034393002/diff/40001/test/mjsunit/regress/regress-typedarray-length.js File test/mjsunit/regress/regress-typedarray-length.js (right): https://codereview.chromium.org/1034393002/diff/40001/test/mjsunit/regress/regress-typedarray-length.js#newcode11 test/mjsunit/regress/regress-typedarray-length.js:11: return a.length; Could you add tests ...
5 years, 9 months ago (2015-03-27 13:22:18 UTC) #3
Toon Verwaest
Added tests
5 years, 8 months ago (2015-03-30 09:06:52 UTC) #4
Dmitry Lomov (no reviews)
On 2015/03/30 09:06:52, Toon Verwaest wrote: > Added tests still lgtm
5 years, 8 months ago (2015-03-30 09:13:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034393002/100001
5 years, 8 months ago (2015-03-30 11:30:38 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-03-30 11:50:08 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 11:50:32 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/87eef73234e7e801b41e5a52a8ebc66f2c3bc602
Cr-Commit-Position: refs/heads/master@{#27519}

Powered by Google App Engine
This is Rietveld 408576698