Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1034343004: Update EME browser_tests to handle early failure (Closed)

Created:
5 years, 9 months ago by jrummell
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update EME browser_tests to handle early failure encrypted_media_browsertest.cc checks receivedKeyMessage after the test page completes. However, receivedKeyMessage is never set in failure cases, so the code times out trying to get the value. Setting receivedKeyMessage to false during initialization to avoid this problem. BUG= TEST=manually created test failures cause EME browser_tests to fail Committed: https://crrev.com/aacbf715042539a5a898fbda504af8faffd299b5 Cr-Commit-Position: refs/heads/master@{#322686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/test/data/eme_player_js/player_utils.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jrummell
A simple change. PTAL.
5 years, 9 months ago (2015-03-27 23:05:30 UTC) #2
sandersd (OOO until July 31)
lgtm
5 years, 9 months ago (2015-03-27 23:17:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034343004/1
5 years, 9 months ago (2015-03-27 23:22:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-28 00:29:57 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-28 00:30:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aacbf715042539a5a898fbda504af8faffd299b5
Cr-Commit-Position: refs/heads/master@{#322686}

Powered by Google App Engine
This is Rietveld 408576698