lib/runtime/dart_runtime.js - Issue 1034273003: fix for static methods and names banned in strict mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart_runtime.js

Issue 1034273003: fix for static methods and names banned in strict mode (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart_runtime.js

diff --git a/lib/runtime/dart_runtime.js b/lib/runtime/dart_runtime.js

index 4033e89ccdc78f9e7d21f87f81ca5fe56b721cad..058c3216b43c96b1b7d8c799f91bdea9a74c2d2f 100644

--- a/lib/runtime/dart_runtime.js

+++ b/lib/runtime/dart_runtime.js

@@ -280,8 +280,9 @@ var dart, _js_helper;

* function with the same name. For example `new SomeClass.name(args)`.

function defineNamedConstructor(clazz, name) {

+ var shortName = name.startsWith('::') ? name.substring(2) : name;

var proto = clazz.prototype;

- var initMethod = proto[clazz.name + '$' + name];

+ var initMethod = proto[clazz.name + '$' + shortName];

var ctor = function() { return initMethod.apply(this, arguments); }

ctor.prototype = proto;

clazz[name] = ctor;