fix for static methods and names banned in strict mode

fix for static methods and names banned in strict mode

* static methods qualified properly
* static method privacy is now enforced
* avoid static method names banned in strict mode
* avoid variable names banned in strict mode

We might want to relax privacy (for both instance and static), but for now it's nice and consistent with instance methods using ES6 Symbol

R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/1753b7085cca2b2cbc6b460b96ac5030ca9e5df1

[Jennifer Messerly, 2015-03-27 21:00:28]

jmesserly@google.com changed reviewers:
+ jacobr@google.com

[Jennifer Messerly, 2015-03-27 21:12:46]

Patchset #1 (id:1) has been deleted

[Jacob, 2015-03-27 21:18:25]

lgtm

https://codereview.chromium.org/1034273003/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1034273003/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:2129: name = '::$name';
FIXME: we should pick something more sane than ::$name so that JS interop is
reasonable for these cases.
I'd suggest at least changing to 
'${name}::' so that JS console autocomplete shows the renamed name.

https://codereview.chromium.org/1034273003/diff/20001/lib/src/utils.dart
File lib/src/utils.dart (left):

https://codereview.chromium.org/1034273003/diff/20001/lib/src/utils.dart#oldc...
lib/src/utils.dart:66: // identifier is not a keyword.
tweak comment to 
is a valid JS variable name
instead of Keyword.

[Jennifer Messerly, 2015-03-27 21:36:41]

good catch, I'm going to try to clean up the callers ... maybe there's another
way to define the named ctor that doesn't trip over strict mode

[Jennifer Messerly, 2015-03-30 17:10:00]

Committed patchset #2 (id:40001) manually as
1753b7085cca2b2cbc6b460b96ac5030ca9e5df1 (presubmit successful).

[Jennifer Messerly, 2015-03-30 17:10:11]

discussed this, going to land with a TODO, as we can probably switch to a better
solution.