Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1034273002: Add matrix constructing helpers to SkMatrix (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add matrix constructing helpers to SkMatrix Committed: https://skia.googlesource.com/skia/+/1d24b8dfe9aac9cadaf3914b8574a4ff6e9bc19d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M bench/DashBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M bench/HairlinePathBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M bench/PathBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M bench/SKPBench.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/aarectmodes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/multipicturedraw.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkMatrix.h View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
robertphillips
5 years, 9 months ago (2015-03-26 22:20:51 UTC) #2
reed2
I don't think we need the warning about using the return result per-se, since there ...
5 years, 9 months ago (2015-03-27 02:50:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034273002/1
5 years, 9 months ago (2015-03-27 02:51:02 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 02:57:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d24b8dfe9aac9cadaf3914b8574a4ff6e9bc19d

Powered by Google App Engine
This is Rietveld 408576698