Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1034203002: Revert "Reland "Allow compaction when incremental marking is on."" (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Reland "Allow compaction when incremental marking is on."" This reverts commit 89ba65fd4970130eea02b675e448a8219ae3d0dd. Reason: crash in v8.detached_context_age_in_gc benchmark. BUG=chromium:450824 LOG=NO NOTRY=true NOTREECHECKS=true TBR=hpayer@chromium.org Committed: https://crrev.com/6431c3939e92e720de8f5c13c3c6a045ea398617 Cr-Commit-Position: refs/heads/master@{#27483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/heap/incremental-marking.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 5 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034203002/1
5 years, 9 months ago (2015-03-26 15:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034203002/1
5 years, 9 months ago (2015-03-26 15:54:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 15:54:56 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 15:55:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6431c3939e92e720de8f5c13c3c6a045ea398617
Cr-Commit-Position: refs/heads/master@{#27483}

Powered by Google App Engine
This is Rietveld 408576698