Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1034193003: Fix 'gn check' errors found in nacl_trusted_plugin target. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
bradnelson, bradn, brettw
CC:
chromium-reviews, brettw, Dirk Pranke, Mark Seaborn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'gn check' errors found in nacl_trusted_plugin target. $ gn gen out-gn $ gn check out-gn //components/nacl/renderer/plugin/* BUG=367595, 376000 TEST=see above R=bradnelson@google.com,brettw@chromium.org TBR=bradnelson@chromium.org Committed: https://crrev.com/5005913739a5c240a4a7acfba2d0e7dd7184f292 Cr-Commit-Position: refs/heads/master@{#322478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/nacl/renderer/plugin/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tfarina
PTAL!
5 years, 9 months ago (2015-03-26 16:35:24 UTC) #1
brettw
lgtm
5 years, 9 months ago (2015-03-26 17:32:58 UTC) #3
bradn
lgtm
5 years, 9 months ago (2015-03-26 20:56:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034193003/1
5 years, 9 months ago (2015-03-26 21:52:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 21:56:11 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 21:59:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5005913739a5c240a4a7acfba2d0e7dd7184f292
Cr-Commit-Position: refs/heads/master@{#322478}

Powered by Google App Engine
This is Rietveld 408576698