Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1034173004: x11: Reset the window handle after destroying it (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

x11: Reset the window handle after destroying it GLSurface::Destroy() could be called from outside the GLSurface implementation. Since it is also called in NativeViewGLSurfaceGLX's destructor, calling Destroy() twice will cause a BadWindow error. BUG=470004 Committed: https://crrev.com/a7927193002ef9c5a79bd74582260acc9f1ef66d Cr-Commit-Position: refs/heads/master@{#322494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/gl/gl_surface_glx.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dnicoara
https://codereview.chromium.org/938873002 adds an explicit call to GLSurface::Destroy() to make sure surfaceless implementations can clean up ...
5 years, 9 months ago (2015-03-26 22:27:30 UTC) #2
piman
lgtm
5 years, 9 months ago (2015-03-26 22:48:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034173004/1
5 years, 9 months ago (2015-03-26 23:08:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 23:30:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:32:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7927193002ef9c5a79bd74582260acc9f1ef66d
Cr-Commit-Position: refs/heads/master@{#322494}

Powered by Google App Engine
This is Rietveld 408576698