Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: src/runtime/runtime-regexp.cc

Issue 1034163002: Use atomic operation to read the length of a fixed array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/heap/heap.h ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/jsregexp-inl.h" 8 #include "src/jsregexp-inl.h"
9 #include "src/jsregexp.h" 9 #include "src/jsregexp.h"
10 #include "src/runtime/runtime-utils.h" 10 #include "src/runtime/runtime-utils.h"
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 if (delta == 0) return *answer; 631 if (delta == 0) return *answer;
632 632
633 Address end_of_string = answer->address() + string_size; 633 Address end_of_string = answer->address() + string_size;
634 Heap* heap = isolate->heap(); 634 Heap* heap = isolate->heap();
635 635
636 // The trimming is performed on a newly allocated object, which is on a 636 // The trimming is performed on a newly allocated object, which is on a
637 // fresly allocated page or on an already swept page. Hence, the sweeper 637 // fresly allocated page or on an already swept page. Hence, the sweeper
638 // thread can not get confused with the filler creation. No synchronization 638 // thread can not get confused with the filler creation. No synchronization
639 // needed. 639 // needed.
640 heap->CreateFillerObjectAt(end_of_string, delta); 640 heap->CreateFillerObjectAt(end_of_string, delta);
641 heap->AdjustLiveBytes(answer->address(), -delta, Heap::FROM_MUTATOR); 641 heap->AdjustLiveBytes(answer->address(), -delta, Heap::SWEEPING_STARTED);
642 return *answer; 642 return *answer;
643 } 643 }
644 644
645 645
646 RUNTIME_FUNCTION(Runtime_StringReplaceGlobalRegExpWithString) { 646 RUNTIME_FUNCTION(Runtime_StringReplaceGlobalRegExpWithString) {
647 HandleScope scope(isolate); 647 HandleScope scope(isolate);
648 DCHECK(args.length() == 4); 648 DCHECK(args.length() == 4);
649 649
650 CONVERT_ARG_HANDLE_CHECKED(String, subject, 0); 650 CONVERT_ARG_HANDLE_CHECKED(String, subject, 0);
651 CONVERT_ARG_HANDLE_CHECKED(String, replacement, 2); 651 CONVERT_ARG_HANDLE_CHECKED(String, replacement, 2);
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 1120
1121 1121
1122 RUNTIME_FUNCTION(Runtime_IsRegExp) { 1122 RUNTIME_FUNCTION(Runtime_IsRegExp) {
1123 SealHandleScope shs(isolate); 1123 SealHandleScope shs(isolate);
1124 DCHECK(args.length() == 1); 1124 DCHECK(args.length() == 1);
1125 CONVERT_ARG_CHECKED(Object, obj, 0); 1125 CONVERT_ARG_CHECKED(Object, obj, 0);
1126 return isolate->heap()->ToBoolean(obj->IsJSRegExp()); 1126 return isolate->heap()->ToBoolean(obj->IsJSRegExp());
1127 } 1127 }
1128 } 1128 }
1129 } // namespace v8::internal 1129 } // namespace v8::internal
OLDNEW
« src/heap/heap.h ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698