Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1034153003: Removed default value for project_bases (Closed)

Created:
5 years, 9 months ago by Sergiy Byelozyorov
Modified:
5 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed default value for project_bases R=machenbach@chromium.org Committed: https://crrev.com/e014bfa819ead24f6befc848dbc77bbc78d10b55 Cr-Commit-Position: refs/heads/master@{#27487}

Patch Set 1 #

Patch Set 2 : Added myself to OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
A testing/commit_queue/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/commit_queue/config.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Sergiy Byelozyorov
5 years, 9 months ago (2015-03-26 14:37:05 UTC) #1
Sergiy Byelozyorov
Michael: can you please also make me a committer in V8 project? I'd like to ...
5 years, 9 months ago (2015-03-26 14:44:02 UTC) #2
Michael Achenbach
lgtm
5 years, 9 months ago (2015-03-26 19:36:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034153003/20001
5 years, 9 months ago (2015-03-26 19:57:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 20:28:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 20:28:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e014bfa819ead24f6befc848dbc77bbc78d10b55
Cr-Commit-Position: refs/heads/master@{#27487}

Powered by Google App Engine
This is Rietveld 408576698